Okio explicit termination method close not called

Question

I have following code in my Android app running in strict mode. I see following exception being thrown. I am closing the response item returned by the code below by invoking response.close() fwiw I am using okio 1.10 and okhttp3 version 3.4.1

Am I using okhttp3 API wrong or issue really is in okio ?

    E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.

StrictMode: A resource was acquired at attached stack trace but never released.
See java.io.Closeable for information on avoiding resource leaks.
java.lang.Throwable: Explicit termination method 'close' not called
at dalvik.system.CloseGuard.open(CloseGuard.java:180)
at java.io.FileOutputStream.<init>(FileOutputStream.java:222)
at okio.Okio.appendingSink(Okio.java:185)
at okhttp3.internal.io.FileSystem$1.appendingSink(FileSystem.java:59)
at okhttp3.internal.cache.DiskLruCache.newJournalWriter(DiskLruCache.java:310)
at okhttp3.internal.cache.DiskLruCache.readJournal(DiskLruCache.java:302)
at okhttp3.internal.cache.DiskLruCache.initialize(DiskLruCache.java:229)
at okhttp3.internal.cache.DiskLruCache.get(DiskLruCache.java:431)
at okhttp3.Cache.get(Cache.java:194)
at okhttp3.Cache$1.get(Cache.java:144)
at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:70)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:124)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:170)
at okhttp3.RealCall.execute(RealCall.java:60)

Code that creates Response object is below.

protected Response getResponse(OkHttpClient client,
                                              String downloadUrl)  {

    Request request = new Request.Builder().
            url(downloadUrl).get().build();

    Call httpRequest = client.newCall(request);

    try {

      return httpRequest.execute();

    }

    catch (Exception e) {

      Timber.e("Error downloading url %s",downloadUrl);

      return null;

    }

}

score 1 · Answer 1 · answered Dec 23 '16 at 20:53

The exception is because the cache file isn't being closed.

Context context;
int httpCacheSize = 100 * 1024 * 1024; // 100mb
File httpCacheDir = new File(context.getCacheDir(), "http");
Cache cache = new Cache(httpCacheDir, httpCacheSize);
OkHttpClient client = new OkHttpClient.Builder()
        .cache(cache)
        .readTimeout(WebServicesManager.READ_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS)
        .connectTimeout(WebServicesManager.CONNECT_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS)
        .build();
Request request = new Request.Builder()
        .url(downloadUrl)
        .get()
        .build();
Response response = null;
try {
    response = client.newCall(request).execute();
} catch (IOException e) {
    e.printStackTrace();
} finally {
    if (response != null) {
        response.close();
    }
    if (!cache.isClosed()) {
        try {
            cache.close();
        } catch (IOException e) {
            e.printStackTrace();
        }
    }
}

I'm getting this error today, but how to solve with current approach where there is no client.newCall() being used? — David, Jul 18 '22 at 01:26

Okio explicit termination method close not called

1 Answers1