while loop not ending when required

Question

So some background information, I'm new to programming and am still learning, so I apologize for my trivial error making. I am making my own text based game just to further practice etc.

Here is the link to everything on dropbox for more context: https://www.dropbox.com/sh/uxy7vafzt3fwikf/B-FQ3VXfsR

I am currently trying to implement the combat system for my game, and I am running into the issue of the combat sequence not ending when required. The 'combat sequence' is a while loop as follows:

public void startCombat()
{

    inCombat = true;

    while(inCombat != false)// && herohealth > 0 && monsterhealth > 0)
    {
        checkAlive();
        heroHitMonster();
        checkAlive();
        monsterHitHero();           
    }          

    attackinghero.setHeroHealth(herohealth);
    attackedmonster.setMonsterHealth(monsterhealth);
}

where the checkAlive() method is as follows:

public void checkAlive()
{    
    if(herohealth <= 0)
    {            
        System.out.println("You have died.");
        attackinghero.clearInventory();
        inCombat = false;

    }

    else if(monsterhealth <= 0)
    {         
        System.out.println("You have killed the "+attackedmonster.getmonsterName()+"!");
        inCombat = false;
        combatlocation.removeMonster(attackedmonster.getmonsterName());
    }    

    else
    {
        //
    }
}

I am trying to get it to end the combat sequence when either the 'hero' or 'monster' health become <= 0, however it is currently finishing the while loop and therefore producing the result of the hero being hit even if he killed the monster in his first hit.

This is what is currently being 'printed to screen'

rat loses 5 health! You have killed the rat!

Hero loses 1 health!

Any help is much appreciated, thanks in advance.

Not your answer, but good programming practice : use while(inCombat) instead of while(inCombat != false). — codingenious, Feb 16 '14 at 09:30
Are you getting the "You have died" and/or "You have killed.." messages? Also, have you 100% confirmed the loop doesn't exit? — David Schwartz, Feb 16 '14 at 09:32
It is not solution but maybe make your code less cryptic. You need to know that `if (x!=false)` is the same as `if (x==true)` which is the same as `if (x)` so maybe change `while(inCombat != false)` to `while(inCombat)`? — Pshemo, Feb 16 '14 at 09:32

score 1 · Answer 1 · answered Feb 16 '14 at 09:34

1

checkAlive shouldn't be void it should be Boolean and should return inCombat, and in your function startCombat you should do inCombat=checkAlive();

answered Feb 16 '14 at 09:34

CodeBird

3,883
2
20
35

score 1 · Answer 2 · answered Feb 16 '14 at 09:36

The while loop will only evaluate after both actions. You need a way to break the loop after the hero hits the monster. I would personally change the checkAlive method to return a boolean, and put the hit methods in if statements in the while loop:

if(checkAlive())
{
    heroHitMonster();
}
if(checkAlive())
{
    monsterHitHero();
}

score 0 · Answer 3 · answered Feb 16 '14 at 09:35

You should end the loop at the end of the checkAlive instead of changing the boolean value. If you killed the monster at first hit, you still execute the monsterHitHero() even, if the monster is killed. The function to hit should be conditioned to the life of heroes/monster.

while loop not ending when required

3 Answers3

Linked

Related