new line appending on my encrypted string

Question

In Main:

public static void main(String[] args) throws NoSuchAlgorithmException {
    System.out.println("encrypt:" + encryptPassword("superuser")+":" );
}

public static String encryptPassword(final String password) throws NoSuchAlgorithmException {
    MessageDigest md = MessageDigest.getInstance("MD5");
    byte[] hashPassword = md.digest(password.getBytes());
    String encryPass = Base64.encodeBase64String(hashPassword);
    return encryPass;
}

I'm getting this output:

encrypt:C66i8K4gFQ23j1jN2sRCqQ==:

But when I implemented the same thing in my application I'm getting the output below:

encrypt:C66i8K4gFQ23j1jN2sRCqQ==
:

Note: new line appending on my encrypted string.

application code:

public boolean authenticateUsernamePasswordInternal(UsernamePasswordCredentials credentials) {
    try {
        System.out.println("encrypt:" + getHash("superuser")+":" );
    } catch (Exception e) {
        logger.error(e.getMessage(), e);
        throw new BadCredentialsAuthenticationException(ErrorConstants.CONNECTION_FAILED);
    }
}

private String getHash(String password) throws NoSuchAlgorithmException, UnsupportedEncodingException{  
    MessageDigest md = MessageDigest.getInstance("MD5");
    byte[] hashPassword = md.digest(password.getBytes());
    String encryPass = Base64.encodeBase64String(hashPassword);
    return encryPass;
}

How I can remove that extra new line. why this is happened, please help me what is the reason?

above "note" output i pasted my output but is coming as space — Rajesh Narravula, Nov 18 '13 at 05:21
Please pay more attention to the formatting of your code. You appear not to have even pasted the full code - your authenticateUsernamePasswordInternal method doesn't have a closing brace. Also, use spaces rather than tabs in Stack Overflow. — Jon Skeet, Nov 18 '13 at 05:22
i added String encryPass = Base64.encodeBase64String(hashPassword).trim(); i getting correct output. but i surprised, same code when i executed in main() method I'm getting correct answer,same thing i implemented in application I'm getting extra new line. why this is happened, please help me **what is the reason?** — Rajesh Narravula, Nov 18 '13 at 05:33
The correct answer is [Dory's answer](https://stackoverflow.com/questions/20040539/new-line-appending-on-my-encrypted-string#25011746), not the accepted one. — palindrom, Feb 26 '15 at 12:02

score 210 · Accepted Answer · answered Jul 29 '14 at 09:07

210

I may be late in answering this, but came across with same problem. Actually problem lies here Base64.encodeBase64String(hashPassword)

Change that line to look like this it should work: Base64.encodeBase64String(hashPassword,Base64.NO_WRAP)

By default the Android Base64 util adds a newline character to the end of the encoded string. The Base64.NO_WRAP flag tells the util to create the encoded string without the newline character.

Check here

answered Jul 29 '14 at 09:07

Dory

7,462
7
33
55

welcome,trimming text would not get correct output always. It was not giving me,so try other options and found solution. :) – Dory Jul 30 '14 at 06:49
1

If you are late answering this, thank I pity everyone who had this problem before you answered it :D – Sridhar Sarnobat Sep 15 '17 at 01:48
1

Why on earth do newlines get inserted? – Conor Patrick Apr 22 '20 at 20:15
1

@ConorPatrick For old programs, not working with long lines. Legacy stuff. Imho no_wrap should be default by now and wrap should be an extra bit flag. – JacksOnF1re Apr 20 '21 at 13:25

score 5 · Answer 2 · answered Oct 12 '18 at 15:11

In case anyone needs this for any libraries using OkHttp, there's a Credentials class you can use for Base64 encoding your username/pass

String credentials = Credentials.basic("username", "password");

request.header(HttpHeaders.AUTHORIZATION, credentials);

score 2 · Answer 3 · answered Dec 17 '13 at 07:00

2

Use:

String encryPass = Base64.encodeBase64String(hashPassword).trim();

answered Dec 17 '13 at 07:00

tashuhka · Answer 4 · 2014-09-12T09:21:42.380

1

A cleaner option without trimming:

String encryPass = BaseEncoding.base64().encode(hashPassword);

edited Sep 12 '14 at 09:21

answered Sep 11 '14 at 09:57

tashuhka

5,028
4
45
64

score 1 · Answer 5 · answered Sep 10 '20 at 07:41

1

You just need to Use Base64 encoding in following way

Base64.encodeBase64String("Your data to encrypt in base64", Base64.DEFAULT)

Change above line with the followings

Base64.encodeBase64String("Your data to encrypt in base64",Base64.NO_WRAP)

It worked for me.

answered Sep 10 '20 at 07:41

Sujeet

558
8
13

`Base64.encodeBase64String("Your data to encrypt in base64",Base64.NO_WRAP)` is the accepted answer. not sure what different in you answer. – Rajesh Narravula Sep 12 '20 at 13:48

score 0 · Answer 6 · answered Nov 18 '13 at 06:40

0

It depends on the implementation of Base64.encodeBase64String(). What is that method?

If it's from Apache commons, be aware that there are a few different classes that handle whitespace differently.

For example, org.apache.commons.net.util.Base64 chunks output, and it probably adds a CR-LF sequence to the final chunk.

The more common version, org.apache.commons.codec.binary.Base64, does not add whitespace.

answered Nov 18 '13 at 06:40

erickson

265,237
58
395
493

1

both places I'm using **org.apache.commons.codec.binary.Base64** – Rajesh Narravula Nov 18 '13 at 07:38
1

Can confirm that with `org.apache.commons.codec.binary.Base64` I'm also getting random trailing whitespace characters. (commons-codec-1.4.jar) – radimpe Feb 28 '14 at 05:38
@radimpe: version 1.4 of that class changed the behavior of the default constructor to do chunking and appends a newline character. v1.3 or v1.5 would not do this. https://issues.apache.org/jira/browse/CODEC-89 – patmortech Jun 24 '15 at 21:53
Luckily there's a well-specified and built-in core Java implementation finally (`java.util.Base64`). – erickson Jun 24 '15 at 21:56

new line appending on my encrypted string

6 Answers6

Linked

Related