Difference between dates

Question

I am using datepicker to allow the user to pick his date of birth and onDateSet() method i am calculating his age. I have read lot of people recommending this but it is giving wrong answer.

Here is my code

class DOBDatePicker extends DialogFragment implements DatePickerDialog.OnDateSetListener{
    @Override
    public Dialog onCreateDialog(Bundle savedInstanceState) {
        // TODO Auto-generated method stub
        // Use the current date as the default date in the picker
        return new DatePickerDialog(BookingFormActivity.this, this, dobYear, dobMonth, dobDay );
    }
    public void onDateSet(DatePicker view, int year, int monthOfYear,
            int dayOfMonth) {
        // TODO Auto-generated method stub
        // Do something with the date chosen by the user
        calOne = Calendar.getInstance();
        calTwo = Calendar.getInstance();

        calOne.set(Calendar.YEAR,Calendar.MONTH, Calendar.DAY_OF_MONTH);
        calTwo.set(year, monthOfYear, dayOfMonth);

          long milliseconds1 = calOne.getTimeInMillis();
          long milliseconds2 = calTwo.getTimeInMillis();

          long diff = milliseconds2 - milliseconds1;
          long sec = diff / 1000 ; 
          long minutes = sec / 60 ;
          long hr = minutes / 60 ;
          long days = hr / 24 ;
          long diffYears = days / 365 ; 
          //long diffYears = (diff / (24 * 60 * 60 * 1000 * 356));  
          Log.d("date", String.valueOf(diffYears));


        dobYear = year;
        dobMonth = monthOfYear;
        dobDay = dayOfMonth;
        updateDOBDateDisplay();
    }
}

what am i doing wrong

Do you want only year in age OR age with day. month and year ? — Manish Dubey, May 17 '13 at 09:59

Graham Borland · Answer 1 · 2013-05-17T10:07:03.077

3

calOne.set(Calendar.YEAR,Calendar.MONTH, Calendar.DAY_OF_MONTH);

This call to Calendar.set(int year, int month, int date) is supposed to take actual values for the year, month and day. Instead, you are passing in the integer field identifiers; see the YEAR example. These values are to identify the field you want to update when you call one of the other methods such as Calendar.set(int field, int value).

I suspect you want to be passing in the values for today's date instead. You can get today's date simply with Calendar.getInstance().

edited May 17 '13 at 10:07

answered May 17 '13 at 09:59

Graham Borland

60,055
21
138
179

after your suggestion i tried with statically entering todays date and it returned the correct answer but when i use dobYear , dobMonth , dobDay it again gives the wrong answer and i use dobYear , dobMonth , dobDay to set the datepicker with current date which works fine. how to resolve this – Ravi May 17 '13 at 10:11

score 2 · Answer 2 · answered May 17 '13 at 10:06

2

Use this code :

// Calender Button onClickListener 
calender.setOnClickListener(new OnClickListener() {
            public void onClick(View v) {
                  showDialog(DATE_DIALOG_ID);
            }
        });

    // ----------To Open datePicker----------------
    private DatePickerDialog.OnDateSetListener pDateSetListener = new DatePickerDialog.OnDateSetListener() {
        public void onDateSet(DatePicker view, int year, int monthOfYear,
                int dayOfMonth) {
            pYear = year;
            pMonth = monthOfYear;
            pDay = dayOfMonth;          
        }
    };

    // To create date dialog
    protected Dialog onCreateDialog(int id) {
        switch (id) {
        case DATE_DIALOG_ID:
            return new DatePickerDialog(this, pDateSetListener, pYear, pMonth,
                    pDay);
        }
        return null;
    }

    // Find out age in year.
    final Calendar cal = Calendar.getInstance();
    int currentYear = cal.get(Calendar.YEAR);
    int nowAge = currentYear - pYear;

answered May 17 '13 at 10:06

Manish Dubey

4,206
8
36
65

Hm, does this mean that if I'm born on Dec last, I'm 1 year old on Jan 1? – Joachim Isaksson May 17 '13 at 10:09
I'll let the asker decide if that's what he really meant :) – Joachim Isaksson May 17 '13 at 10:12
One day baby old will not use Android phones for registering himself in any app. Lolz. – Manish Dubey May 17 '13 at 10:14
thanks for the answer but i figured out what i was doing from the answer below and since its working why to create this issue of one year. – Ravi May 17 '13 at 10:22
SO you have any solution to remove 1 year issue ? – Manish Dubey May 17 '13 at 10:29

score 2 · Accepted Answer · answered May 17 '13 at 10:06

2

You just need to remove the line

calOne.set(Calendar.YEAR,Calendar.MONTH, Calendar.DAY_OF_MONTH);

The line

calOne = Calendar.getInstance();

sets the time to the current time anyway.

Your code also doesn't take account of leap years, so might give problems in certain cases.

answered May 17 '13 at 10:06

HexAndBugs

5,549
2
27
36

thanks it worked . one more thing i am checking the output in logCat everytime the date is set the answer is shown twice – Ravi May 17 '13 at 10:21

Difference between dates

3 Answers3