Node.js mysql query syntax issues UPDATE WHERE

Question

I trying to update some info in MYSQL DB, but I'm not sure of how to do it with in node.js. This is the mysql driver I'm using https://github.com/felixge/node-mysql

What I have so far

connection.query('SELECT * FROM users WHERE UserID = ?', [userId], function(err, results) {
if (results[0]) {
if (results[0].Name!=name) {
console.log(results[0].Name);
connection.query('UPDATE users SET ? WHERE UserID = ?', [userId], {Name: name});
}
console.log(results[0].UserID);
}
});

Everything works except...

connection.query('UPDATE users SET ? WHERE UserID = ?', [userId], {Name: name});

In PHP I would have this...

mysql_query("UPDATE users SET Name='".$_GET["name"]."' WHERE UserID='".$row['UserID']."'");

I'm not sure what I'm doing wrong, But I'm positive that the issue is here

connection.query('UPDATE users SET ? WHERE UserID = ?', [userId], {Name: name});

score 52 · Answer 1 · edited Aug 22 '19 at 10:08

52

The answer by ruakh isn't entirely correct, you can use the SET ? feature with another ?.

The syntax is:

connection.query('UPDATE users SET ? WHERE UserID = ?', [{ Name: name }, userId])

edited Aug 22 '19 at 10:08

Josh Laird

6,974
7
38
69

answered Oct 14 '13 at 10:57

Bala Clark

1,524
12
19

Thank you so much, sir! – upupming Apr 19 '19 at 17:45

ruakh · Accepted Answer · 2016-04-29T17:02:30.203

[Note (added 2016-04-29): This answer was accepted, but it turns out that there is a reasonable way to use SET ?. For details, see Bala Clark's answer on this same page. —ruakh]

From the code for Connection.prototype.query() and Connection.createQuery(), it's clear that you can only pass in a single values object. I don't see where the code for the special SET ? behavior is defined — it's clearly not in SqlString.formatQuery() — but if it uses SqlString.objectToValues(), then I guess there's no way to use it together with another ?.

I think the best approach is to just dispense with the neat SET ? feature, and write either of these:

connection.query('UPDATE users SET Name = ? WHERE UserID = ?', [name, userId])

connection.query('UPDATE users SET Name = :Name WHERE UserID = :UserID',
                     {UserID: userId, Name: name})

but if you really want to use SET ?, I suppose you could write this:

connection.query('UPDATE users SET ? WHERE UserID = :UserID',
                     {UserID: userId, Name: name})

which would update both UserID and Name; unless you have a trigger, this should be O.K., in that it's updating UserID to the value it already had anyway. But it's kind of disconcerting, and I don't recommend it.

@MarcioJasinski: Thanks for your edit suggestion, but it really changes this answer in a way that will invalidate other answers on this page. I'll see if I can find a more graceful way to add that information . . . — ruakh, Apr 29 '16 at 16:57
You should mention that in order for your `:Name` and `:UserId` implementation to work one needs to include a [custom-format](https://github.com/mysqljs/mysql#custom-format) configuration. — DrDirk, Jan 20 '18 at 19:06

Marcel · Answer 3 · 2016-05-12T06:40:43.967

22

You can use an array of objects:

connection.query('UPDATE user SET ? WHERE ?', [{ Name: name }, { UserId: userId }])

edited May 12 '16 at 06:40

answered Apr 02 '14 at 08:57

Marcel

7,909
5
22
25

1

how can I use OR in this query after WHERE? – mynameisbutt Apr 06 '18 at 15:18

score 0 · Answer 4 · answered Sep 22 '18 at 07:18

This is what worked for me

 var records = 
 [name,email,adhar,ROLE,NOTES,REQUESTFORSUPPLIER,PASSWORD,LOCATION,CREATEDBY,CREATEDON,MODIFIEDBY,MODIFIEDON,mobile];

    var sql="UPDATE flavica_user SET Name=?,EMAIL=?,AADHAR=?,ROLE=?,NOTES=?,REQUESTFORSUPPLIER=?,PASSWORD=?,LOCATION=?,CREATEDBY=?,CREATEDON=?,MODIFIEDBY=?,MODIFIEDON=? WHERE USER_MOBILE=?"
    //var sql="UPDATE `flavica_user` SET ? WHERE ?";
    //this sql updates flavica_user
    con.query(sql,records,(err,result)=>{

      if(err){
        res.json({
          status:400,
          message:err
        })
      }

      else{
        res.json({
          status:200,
          message:result
        })
      }

    })

score 0 · Answer 5 · answered Apr 16 '21 at 02:59

let query_1 =  `UPDATE reindexing_status SET success="Failure" where status="In Progress"`;
await updateValues(db_connection,query_1);
 
if(lambdaInvokeStatusCode === 200)

{
   let query_1 =  `UPDATE reindexing_status SET success="Success" where status="In Progress"`;
   await updateValues(db_connection,query_1);
   
   let query_2 =  `UPDATE reindexing_status SET end_time='${indexedAt}' where status="In Progress"`;
   await updateValues(db_connection,query_2);
   
   let query_3 =  `UPDATE reindexing_status SET status="Complete" where status="In Progress"`;
   await updateValues(db_connection,query_3);
   

}



async function updateValues(db_connection,sql) {
await new Promise((resolve, reject) => {
    db_connection.query(sql, function (err, result) {
        if (err) {
            console.log(err);
            reject(err);
        }
        else {
           
            console.log("RDS Updated Successfully",result );
            resolve("RDS URL Column: " + JSON.stringify(result));
        }
    });
 
});
}

akshat chawla · Answer 6 · 2022-12-23T11:02:42.000

0

connection.query('UPDATE users SET Column_name = ? WHERE UserID = ?', [update_Value, userId]);

edited Dec 23 '22 at 11:02

answered Dec 22 '22 at 08:55

akshat chawla

39
8

Node.js mysql query syntax issues UPDATE WHERE

6 Answers6

Linked