Combine Date and Time

Question

I need to combine date and time and insert into one datetime row.

Here is my code:

 DateTime Headlinedate;

 try
 {
     DateTime date = Convert.ToDateTime(txtHeadlinedate.Text.Trim(), Ci);
     string timestr = DateTime.Now.ToString("hh:mm:ss tt");
     DateTime combinedDate = date.Add(TimeSpan.Parse(timestr));
     Headlinedate = combinedDate;

 }
 catch {
     Headlinedate = DateTime.Now;
 }

I'm getting exception :

Input string was not in a correct format

`DateTime combinedDate = date.Add(DateTime.Now.TimeOfDay);` instead of parsing `TimeSpan` from string. — Habib, Feb 20 '13 at 07:55

score 4 · Accepted Answer · edited Feb 20 '13 at 07:55

4

If you get this exception of the first line of code, you'll have to make sure that the content of txtHeadlinedate is valid and parse it accordingly.

If the error comes from the call to TimeSpan.Parse, the following version should fix the problem:

DateTime date = Convert.ToDateTime(txtHeadlinedate.Text.Trim(), Ci);
Headlinedate = date.Add(DateTime.Now.TimeOfDay);

edited Feb 20 '13 at 07:55

Soner Gönül

97,193
102
206
364

answered Feb 20 '13 at 07:54

ybo

16,967
2
28
31

To make absolutely sure you get no time-of-day component from the first line (the conversion of the text string), you could add a `.Date` to the end of the first line. – Jeppe Stig Nielsen Feb 20 '13 at 08:58

dotNET · Answer 2 · 2013-02-20T08:01:41.363

2

TimeSpan can't parse "tt". Use DateTime to parse it, or instead use HH:mm format to get 24-hour value of hours and remove tt part from your format. Then TimeSpan will be able to parse it. For example:

DateTime date = Convert.ToDateTime(txtHeadlinedate.Text.Trim(), Ci);
string timestr = DateTime.Now.ToString("HH:mm:ss");
DateTime combinedDate = date.Add(TimeSpan.Parse(timestr));
Headlinedate = combinedDate;

edited Feb 20 '13 at 08:01

answered Feb 20 '13 at 07:56

dotNET

33,414
24
162
251

1

It's not really necessary to convert "now" into a time string and then convert the string back to a `TimeSpan`. – Jeppe Stig Nielsen Feb 20 '13 at 09:08
Right, which makes is essentially the same as ybo's answer. Thanks. – dotNET Feb 21 '13 at 08:55

score 0 · Answer 3 · answered Feb 20 '13 at 07:57

0

date.Hour=DateTime.Now.Hour;
date.Minute=DateTime.Now.Minute;
date.Second=DateTime.Now.Second;

answered Feb 20 '13 at 07:57

Shaiju Poozhikkunnu

96
8

3

that's a rather poor answer why are you doing 3 steps when you can do it in one step..? – MethodMan Feb 20 '13 at 07:58
And this is relevant with this question because..? – Soner Gönül Feb 20 '13 at 07:59
First, you shouldn't read the `Now` property more than one time. The clock may change, so if it's `09:59:59` when you read the first part, and `10:00:00` when you read the last part, you might get a mix like `09:00:00` which is far from the true "now". Also if your `date` identifier is supposed to be a `DateTime` value, you can mutate it like you do. The properties in question are `get`-only (no setters). Downvoted. – Jeppe Stig Nielsen Feb 20 '13 at 09:03

score 0 · Answer 4 · edited Feb 20 '13 at 08:03

Use DateTime.TryParse and pass your txtHeadlinedate.Text.Trim() value

DateTime.TryParse(String, IFormatProvider, DateTimeStyles, DateTime)

And for adding timespan value either use

DateTime myDate = ExistingTime.Date.AddHours(hh).AddMinutes(min);

or // Calculate what day of the week is 36 days from this instant.(like below)

System.DateTime today = System.DateTime.Now; System.TimeSpan duration = new System.TimeSpan(36, 0, 0, 0); System.DateTime answer = today.Add(duration);

score 0 · Answer 5 · answered Feb 20 '13 at 08:01

0

I guess this should work

DateTime Headlinedate;
try
         {
             DateTime date = Convert.ToDateTime(txtHeadlinedate.Text.Trim(), Ci);
             string timestr = DateTime.Now.ToString("MM/dd/yyyy HH:MM:ss");// here is the solution
             DateTime combinedDate = date.Add(TimeSpan.Parse(timestr));
             Headlinedate = combinedDate;

         }
         catch {
             Headlinedate = DateTime.Now;
         }

answered Feb 20 '13 at 08:01

Pankaj Nagarsekar

219
1
6
17

1

Don't use `"MM"` for minutes; it's _months_. It wasn't the purpose to get the date part of `Now`. It really isn't necessary to use `ToString` here. – Jeppe Stig Nielsen Feb 20 '13 at 09:10

score -1 · Answer 6 · answered Feb 20 '13 at 08:06

-1

DateTime date = Convert.ToDateTime(txtHeadlinedate.Text.Trim(), Ci);    
DateTime combinedDate = new DateTime(date.Year, date.Month, date.Day, DateTime.Now.Hour, DateTime.Now.Minute, DateTime.Now.Second);

answered Feb 20 '13 at 08:06

gregjer

2,823
2
19
18

score -1 · Answer 7 · edited Dec 10 '15 at 00:49

This works!

DateTime _dateOnly = DateTime.Now;
DateTime _timeOnly = DateTime.Now;

public DateTime Combined { get; set; }

      public DateTime DateOnly
        {
            get { return _dateOnly.Date; }
            set
            {
                _dateOnly = value.Date;
                Combined = DateOnly.Add(TimeOnly.TimeOfDay);
            }
        }

        public DateTime TimeOnly
        {
            get { return _timeOnly.ToLocalTime(); }
            set
            {
                _timeOnly = value.ToLocalTime();
                Combined = DateOnly.Add(TimeOnly.TimeOfDay);
            }
        }

Combine Date and Time

7 Answers7