Should I free the C array I pass into NSBezierPath's setLineDash:count:phase: method?

Question

I am setting the line dash style on an NSBezierPath instance:

NSBezierPath *path = [NSBezierPath path];
// Get the path information...

NSInteger count = 0;
// Get the array count...

CGFloat *dashLengths = (CGFloat *)malloc(sizeof(CGFloat) * count);
// Populate the array...

CGFloat phase = 0.0f;
// Get the phase...

[path setLineDash:dashLengths count:count phase:phase];

Should I call free() on dashLengths to prevent a memory leak? Or would releasing the array cause a error later on?

score 1 · Accepted Answer · answered Feb 19 '13 at 16:49

1

Why are you using malloc in the first place? Just declare

CGFloat dashLengths[count];

Now dashLengths is an automatic variable. No memory management required.

answered Feb 19 '13 at 16:49

matt

515,959
87
875
1,141

Thanks! I forgot you could make C arrays this way. – d-squared Feb 19 '13 at 20:10

score 0 · Answer 2 · answered Feb 19 '13 at 16:42

0

No, you must free() that malloc()'d array yourself.

answered Feb 19 '13 at 16:42

trojanfoe

120,358
21
212
242

score 0 · Answer 3 · answered Feb 19 '13 at 16:43

0

You should call free() on dashLengths right after you free path. NSBezierPath has no way of retaining it, since it's just a regular ol pointer, so you should not take that memory away until NSBezierPath goes away.

answered Feb 19 '13 at 16:43

escrafford

2,373
16
19

Should I free the C array I pass into NSBezierPath's setLineDash:count:phase: method?

3 Answers3