Android Alert Dialog is not showing

Question

I'm comparing the strings, if all are equal it has to show a dialog "ALL ARE EQUAL" else another dialog "NOT EQUAL". I want to use only OK button in Alert Dialog. And my code:

if(s1.equals("yes") && s2.equals("yes") && s3.equals("yes") && s4.equals("yes"))
        showA();

Where the showA() method is

private void showA() {
    AlertDialog.Builder ab = new AlertDialog.Builder(this);
    ab.setTitle("Hello!!");
    ab.setMessage("ALL ARE EQUAL");
    ab.setCancelable(false);
    ab.setPositiveButton("OK", new DialogInterface.OnClickListener() {

        @Override
        public void onClick(DialogInterface dialog, int which) {
            // TODO Auto-generated method stub

        }
    });
    AlertDialog ad = ab.create();

    ad.show();

}

Is there any error in logcat?? Put a break point or put a log inside if or showA() to check whether showA() is ever called or not — Android, Dec 20 '12 at 09:11
Whats your problem? Please try to give more information on what exactly u want from SO? — Avadhani Y, Dec 20 '12 at 09:11
you should write a log trace in the method showA, maybe it method never run — frayab, Dec 20 '12 at 09:11

score 10 · Accepted Answer · edited Mar 04 '14 at 07:54

10

If it doesn't go inside method, I think your string might be "YES" or "Yes".

Why don't you try it as shown below?

if(s1.equalsIgnoreCase("yes") && s2.equalsIgnoreCase("yes") && s3.equalsIgnoreCase("yes") && s4.equalsIgnoreCase("yes"))
    showA();

edited Mar 04 '14 at 07:54

lukad

17,287
3
36
53

answered Dec 20 '12 at 09:10

MysticMagicϡ

28,593
16
73
124

1

yea.. My String was 'Yes'. now i changed it.! Thanks – DroidLearner Dec 20 '12 at 09:14

score 4 · Answer 2 · answered Dec 20 '12 at 09:13

4

Seem your string s1,s2,s3 &s s4 is in undefined case, better to use equalsIgnoreCase like below:

s1.equalsIgnoreCase("yes")

instead

s1.equals("yes")

answered Dec 20 '12 at 09:13

RobinHood

10,897
4
48
97

score 2 · Answer 3 · edited Dec 20 '12 at 09:17

if(s1.equalsIgnoreCase("yes") && s2.equalsIgnoreCase("yes") && s3.equalsIgnoreCase("yes") && s4.equalsIgnoreCase("yes"))      {
        showA();
} else {
     showB()
}

private void showA() {
    AlertDialog.Builder ab = new AlertDialog.Builder(this);
    ab.setTitle("Hello!!");
    ab.setMessage("ALL ARE EQUAL");
    ab.setCancelable(false);
    ab.setPositiveButton("OK", new DialogInterface.OnClickListener() {

        @Override
        public void onClick(DialogInterface dialog, int which) {
            // TODO Auto-generated method stub

        }
    });
    AlertDialog ad = ab.create();

    ad.show();    
}

private void showB() {
    AlertDialog.Builder ab = new AlertDialog.Builder(this);
    ab.setTitle("Hello!!");
    ab.setMessage("NOT EQUAL");
    ab.setCancelable(false);
    ab.setPositiveButton("OK", new DialogInterface.OnClickListener() {

        @Override
        public void onClick(DialogInterface dialog, int which) {
            // TODO Auto-generated method stub

        }
    });
    AlertDialog ad = ab.create();

    ad.show();   
}

You require something like this.

score 1 · Answer 4 · answered Dec 20 '12 at 09:16

1

Your Code works absolutely fine. Just make sure your strings are equal to yes Case-Sensitive.

answered Dec 20 '12 at 09:16

Zeeshan

741
1
7
21

score 0 · Answer 5 · answered Dec 20 '12 at 09:23

0

First of all you have to check value of s1,s2,s3,s4 and then compare.

your code is right,.

answered Dec 20 '12 at 09:23

Harshid

5,701
4
37
50

score 0 · Answer 6 · edited Dec 24 '12 at 10:00

if(s1.equalsIgnoreCase("yes") && s2.equalsIgnoreCase("yes") && s3.equalsIgnoreCase("yes") && 

s4.equalsIgnoreCase("yes"))      {


       showAlertDialog("All ARE EQUAL");

} else {

     showAlertDialog("All ARE NOT EQUAL");
}



private void showAlertDialog(String msg){

    AlertDialog.Builder ab = new AlertDialog.Builder(this);
    ab.setTitle("Hello!!");
    ab.setMessage(msg);
    ab.setCancelable(false);
    ab.setPositiveButton("OK", new DialogInterface.OnClickListener() {

        @Override
        public void onClick(DialogInterface dialog, int which) {
            // TODO Auto-generated method stub

        }
    });
    AlertDialog ad = ab.create();

    ad.show();    

}

Don't put the same code twice, just create a method and pass the parameter which you require.

Android Alert Dialog is not showing

6 Answers6