What's the standard pattern for ember-data validations? (invalid state, becameInvalid...)

Question

I've kinda been struggling with this for some time; let's see if somebody can help me out.

Although it's not explicitly said in the Readme, ember-data provides somewhat validations support. You can see that on some parts of the code and documentation:

https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/model/states.js#L411

https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/model/states.js#L529

The REST adapter doesn't add validations support on itself, but I found out that if I add something like this in the ajax calls, I can put the model on a "invalid" state with the errors object that came from the server side:

error: function(xhr){
  var data = Ember.$.parseJSON(xhr.responseText);
  store.recordWasInvalid(record, data.errors);
}

So I can easily to the following:

var transaction = App.store.transaction();
var record = transaction.createRecord(App.Post);
record.set('someProperty', 'invalid value');
transaction.commit()
// This makes the validation fail

record.set('someProperty', 'a valid value');
transaction.commit();
// This doesn't trigger the commit again.

The thing is: As you see, transactions don't try to recommit. This is explained here and here.

So the thing is: If I can't reuse a commit, how should I handle this? I kinda suspect that has something to do to the fact I'm asyncronously putting the model to the invalid state - by reading the documentation, it seems like is something meant for client-side validations. In this case, how should I use them?

score 4 · Answer 1 · answered Jan 09 '13 at 18:37

4

I have a pending pull request that should fix this

https://github.com/emberjs/data/pull/539

answered Jan 09 '13 at 18:37

Cyril Fluck

1,561
7
9

webjprgm · Answer 2 · 2012-12-04T18:05:26.760

2

I tried Javier's answer, but I get "Invalid Path" when doing any record.set(...) with the record in invalid state. What I found worked was:

// with the record in invalid state
record.send('becameValid');
record.set('someProperty', 'a valid value');
App.store.commit();

Alternatively, it seems that if I call record.get(...) first then subsequent record.set(...) calls work. This is probably a bug. But the above work-around will work in general for being able to re-commit the same record even without changing any properties. (Of course, if the properties are still invalid it will just fail again.)

edited Dec 04 '12 at 18:05

answered Dec 04 '12 at 17:56

webjprgm

4,331
2
18
14

I've added `record.send('becameValid');` in my model `becomeInvalid` function. This worked around my problem. This is inspired by a comment on GitHub pull request from Cyril. – ybart Apr 11 '13 at 09:59

score 1 · Answer 3 · answered Jun 22 '12 at 23:51

1

this may seem to be an overly simple answer, but why not create a new transaction and add the pre-existing record to it? i'm also trying to figure out an error handling approach.

also you should probably consider writing this at the store level rather than the adapter level for the sake of re-use.

answered Jun 22 '12 at 23:51

Adam Krawesky

1,313
11
23

1

wouldn't this be problematic since you can't add dirty objects to transactions? – Alexander Wallace Matchneer Oct 01 '12 at 15:21

score 1 · Answer 4 · answered Oct 31 '12 at 11:05

1

For some unknown reason, the record becomes part of the store default transaction. This code works for me:

var transaction = App.store.transaction();
var record = transaction.createRecord(App.Post);
record.set('someProperty', 'invalid value');
transaction.commit()

record.set('someProperty', 'a valid value');
App.store.commit(); // The record is created in backend

The problem is that after the first failure, you must always use the App.store.commit() with the problems it has.

answered Oct 31 '12 at 11:05

Javier Aranda

41
5

I might be wrong, but I think it gets associated as the default transaction unless you specifically define a context. – Marco Nov 14 '12 at 03:01
Do you have any examples of that? – Javier Aranda Nov 26 '12 at 12:31

score 0 · Answer 5 · answered May 09 '13 at 22:10

0

Give a look at this gist. Its the pattern that i use in my projects.

https://gist.github.com/danielgatis/5550982

answered May 09 '13 at 22:10

danielgatis

737
7
19

score 0 · Answer 6 · answered Jan 11 '23 at 15:53

@josepjaume

Take a look at https://github.com/esbanarango/ember-model-validator.

Example:

import Model, { attr } from '@ember-data/model';
import { modelValidator } from 'ember-model-validator';

@modelValidator
export default class MyModel extends Model {
  @attr('string') fullName;
  @attr('string') fruit;
  @attr('string') favoriteColor;

  validations = {
    fullName: {
      presence: true
    },
    fruit: {
      presence: true
    },
    favoriteColor: {
      color: true
    }
  };
}

What's the standard pattern for ember-data validations? (invalid state, becameInvalid...)

6 Answers6

Linked