When I am scrolling up SwipeRefreshLayout refreshing my app

Question

I am created an app that downloaded some data from internet and show them in a list using recyclerView.So I added SwipeRefreshLayout so that when user is at the beginning of the page he can pull from top to refresh (like facebook app).But In my app when I scroll down and again trying to scrolling up the SwipeRefreshLayout shows up and refreshing my page.

I also search the internet but can't get the right answer.

I try this solution but it doesn't work anymore(Because I am using recyclerView).

Here is some of the code of my app for better understanding...

activity_main

<android.support.v4.widget.SwipeRefreshLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/swipeToRefresh"
android:layout_height="match_parent"
android:layout_width="match_parent">
<include layout="@layout/content_main"/>
</android.support.v4.widget.SwipeRefreshLayout>

MainActivity.java

//.....
public SwipeRefreshLayout mSwipeRefreshLayout;

protected void onCreate(Bundle savedInstanceState) {
//....
mSwipeRefreshLayout = (SwipeRefreshLayout) findViewById(R.id.swipeToRefresh);
    mSwipeRefreshLayout.setOnRefreshListener(this);
//......
}

//.......

@Override
public void onRefresh() {
    Api.getBlog(mBlogListAdapter);
}

Api Response

 //.......
 @Override
public void onResponse(Call<AllBlog> call, Response<AllBlog> response) {
    //.......
    mActivity.mSwipeRefreshLayout.setRefreshing(false);
}

In my adapter

//........
public class BlogListViewHolder extends RecyclerView.ViewHolder implements View.OnScrollChangeListener{
    public ImageView mBlogImage;
    public TextView mBlogTitle;
    public TextView mBlogAuthor;
    public BlogListViewHolder(View itemView) {
        super(itemView);
        mBlogImage = (ImageView) itemView.findViewById(R.id.blogPhoto);
        mBlogTitle = (TextView) itemView.findViewById(R.id.blogTitle);
        mBlogAuthor = (TextView) itemView.findViewById(R.id.blogAuthor);
    }
}

I also tried implementing View.OnScrollChangeListener but it also not work.

public class BlogListViewHolder extends RecyclerView.ViewHolder implements View.OnScrollChangeListener{
    public ImageView mBlogImage;
    public TextView mBlogTitle;
    public TextView mBlogAuthor;
    public BlogListViewHolder(View itemView) {
        super(itemView);
        mBlogImage = (ImageView) itemView.findViewById(R.id.blogPhoto);
        mBlogTitle = (TextView) itemView.findViewById(R.id.blogTitle);
        mBlogAuthor = (TextView) itemView.findViewById(R.id.blogAuthor);

        itemView.setOnScrollChangeListener(this);
    }

    @Override
    public void onScrollChange(View v, int scrollX, int scrollY, int oldScrollX, int oldScrollY) {
        if (v.getVerticalScrollbarPosition() == 0) {
            mActivity.mSwipeRefreshLayout.setEnabled(true);
        } else {
            mActivity.mSwipeRefreshLayout.setEnabled(false);
        }
    }
}

Please post your code for `content_main.xml`. – Chintan Soni Mar 29 '16 at 11:38 — Chintan Soni, Mar 29 '16 at 11:38

score 17 · Accepted Answer · answered Mar 29 '16 at 11:37

17

I think you have implemented SwipeRefreshLayout to whole layout itself. This is not the correct way to implement SwipeRefreshLayout. You should wrap SwipeRefreshLayout to just your RecyclerView, instead of whole layout.

Like below:

<android.support.v4.widget.SwipeRefreshLayout
...
>
    <RecyclerView 
     ...
    />
</android.support.v4.widget.SwipeRefreshLayout>

answered Mar 29 '16 at 11:37

Chintan Soni

24,761
25
106
174

Thanks man.I just put my whole layout into SwipeRefreshLayout.When wrap only recyclerview using SwipeRefreshLayout the problem solved – Niyamat Ullah Mar 30 '16 at 06:54
@ChintanSoni please answer this too: http://stackoverflow.com/questions/36434071/android-support-v4-widget-swiperefreshlayout-working-but-it-is-not-visible – Apr 05 '16 at 18:35

score 0 · Answer 2 · answered Mar 29 '16 at 11:22

0

 //create interface
  public interface YourFragmentInterface {
   void fragmentBecameVisible();
  }

 //implements YourFragmentInterface

        @Override
        public void fragmentBecameVisible() 

        // refresh detail
        }

answered Mar 29 '16 at 11:22

pamitha

55
1
5

score 0 · Answer 3 · answered Apr 18 '18 at 05:00

Use SwipeRefreshLayout this way.

<android.support.v4.widget.SwipeRefreshLayout 
xmlns:android="http://schemas.android.com/apk/res/android"
        android:id="@+id/swipeContainer"
        android:layout_width="match_parent"
        android:layout_height="match_parent">
    <android.support.v7.widget.RecyclerView
        android:id="@+id/Recycler_view"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:background="#e0e0e0"
        android:overScrollMode="never"> 
</android.support.v7.widget.RecyclerView>
    </android.support.v4.widget.SwipeRefreshLayout>

score 0 · Answer 4 · answered Apr 26 '22 at 09:44

For me I had to remove the following line which I had added to test something else,

recyclerView.setNestedScrollingEnabled(false);

And for the record, I have applied SwipeRefreshLayout to the whole layout itself, not wrapped it to just my RecyclerView. Dunno if it is right or wrong but it does work.

Hope this helps someone!

When I am scrolling up SwipeRefreshLayout refreshing my app

4 Answers4

Linked

Related