before_create doesn't work in rails

Question

In a rails project, I have 3 controllers and models, user, responsibility and profile. I have below code:

user.rb

class User < ActiveRecord::Base
  # Include default devise modules. Others available are:
  # :confirmable, :lockable, :timeoutable and :omniauthable
  devise :database_authenticatable, :registerable,
         :recoverable, :rememberable, :trackable, :validatable

  has_one :responsibility
  has_one :profile

  before_create :build_responsibility
  before_create :build_profile

end

responsibility.rb

class Responsibility < ActiveRecord::Base

  belongs_to :user

end

profile.rb

class Profile < ActiveRecord::Base

  belongs_to :user

  validates :user_id, uniqueness: true

  validates_numericality_of :nic_code, :allow_blank => true
  validates_numericality_of :phone_number

  validates_length_of :phone_number, :minimum => 11, :maximum => 11
  validates_length_of :nic_code, :minimum => 10, :maximum => 10, :allow_blank => true

  has_attached_file :photo, :styles => { :medium => "300x300>", :thumb => "35x35>" }, :default_url => "profile-missing.jpg"
  validates_attachment_content_type :photo, :content_type => [ 'image/gif', 'image/png', 'image/x-png', 'image/jpeg', 'image/pjpeg', 'image/jpg' ]

end

Now, when I created a new user, before_create works for responsibility and creates it, but for profile it's not working and doesn't create a new profile. Is there a difference between profile and responsibility? Why before_create works for responsibility, but doesn't work for profile?

`build_responsibility` - t's some build-in activerecord method? Or why you didn't show it? — zishe, May 17 '14 at 07:06
Post your `before_create` code,so that it is easy to find a solution. — Pavan, May 17 '14 at 07:07
looks like it's really build in [method](http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-belongs_to) — zishe, May 17 '14 at 07:08
I just use `before_create` and don't have any code for `before_create`. — mgh, May 17 '14 at 07:10
is `before_create` a rails built-in helper? I could't find it in `api` — Wally Ali, May 17 '14 at 07:10
You should be using some method with `before_create` right? Post that method. — Pavan, May 17 '14 at 07:11
@WaliAli http://api.rubyonrails.org/classes/ActiveRecord/Callbacks.html — Richard Peck, May 17 '14 at 07:11
`before_create` allows you to build objects on the fly with `build_[object]` - it just creates a blank version of the associative model, with your `foreign_key` populated — Richard Peck, May 17 '14 at 07:11

score 5 · Accepted Answer · edited May 23 '17 at 11:57

5

This will almost certainly be a validation issue:

#app/models/profile.rb
validates_length_of :phone_number, :minimum => 11, :maximum => 11
validates_length_of :nic_code, :minimum => 10, :maximum => 10, :allow_blank => true

When you build an ActiveRecord object, the models will not be populated with data. This means your validations are going to have no data to validate, which I believe will throw the error

You need to test by removing the length & presence validations in your Profile model:

#app/models/profile.rb
class Profile < ActiveRecord::Base
  belongs_to :user

  # -> test without validations FOR NOW
end

edited May 23 '17 at 11:57

Community

1
1

answered May 17 '14 at 07:09

Richard Peck

76,116
9
93
147

1

I set `:allow_blank => true` to all validation field and it's work, Thanks. – mgh May 17 '14 at 07:16
Thanks this makes sense. Also, I found this guide to be useful: https://api.rubyonrails.org/classes/ActiveRecord/Callbacks.html – Robert Vunabandi May 17 '20 at 17:58

before_create doesn't work in rails

1 Answers1

Linked