11

Consider the following: An instance of an Objective-C class is referenced by one strong reference and one weak reference (under ARC). On thread X, a method is called on the instance via the weak reference. On thread Y, the strong reference is broken such that there are no more strong references to the instance, and it should be deallocated.

Is this situation possible, in that the object might be deallocated on thread Y while the method is executing on thread X? Similarly, does invoking a method on an object 'retain' that object until the method returns?

Andrew Hershberger
  • 4,152
  • 1
  • 25
  • 35

1 Answers1

15

ARC actually does retain weak references before calling instance methods on them, and releases after the call.

I was researching this issue and was corrected by a colleague after showing him this stackoverflow question. He pointed to this: http://lists.apple.com/archives/objc-language/2012/Aug/msg00027.html

Sure enough, in the assembly, ARC retains and releases around an invocation on a weak reference.

One time you will want to listen to CLANG_WARN_OBJC_RECEIVER_WEAK is for nil checks, when nil could cause an error.

if (self.weakRefToParent) {
    //self.weakRefToParent could be dealloced and set to nil at this line
    NSString *name = [self.weakRefToParent name]; //CLANG_WARN_OBJC_RECEIVER_WEAK warning
    [self.namesArray addObject:name];  //name is nil, NSInvalidArgumentException
}

This is the safer way:

Parent *strongRefToParent = self.weakRefToParent;
if (strongRefToParent) {
    NSString *name = [strongRefToParent name];
    [self.namesArray addObject:name];
}
James Mitchell
  • 384
  • 2
  • 9
  • 2
    Much better answer (as in "accurate and based on Compiler author's definitive response"). Thanks! – bbum Jan 29 '13 at 18:39
  • If this is true, then why are there crashes like this one? https://stackoverflow.com/questions/9068820/objective-c-ios-dealloc-is-being-called-in-middle-of-execution-of-webviewdid/9068896 – fabb Jul 12 '18 at 04:28
  • This question is about invoking on weak references, it seems like something else is going on in that other issue. – James Mitchell Jul 12 '18 at 19:31