186

I am trying to write a script which automatically checks out or updates a Subversion URL based on whether a specified directory exists or not.

For some reason, my code isn't working and always returns true even if it's false:

def directory_exists?(directory)
  return false if Dir[directory] == nil
  true
end

What am I doing wrong?

Timur Shtatland
  • 12,024
  • 2
  • 30
  • 47
Ash
  • 24,276
  • 34
  • 107
  • 152

5 Answers5

320

If it matters whether the file you're looking for is a directory and not just a file, you could use File.directory? or Dir.exist?. This will return true only if the file exists and is a directory.

As an aside, a more idiomatic way to write the method would be to take advantage of the fact that Ruby automatically returns the result of the last expression inside the method. Thus, you could write it like this:

def directory_exists?(directory)
  File.directory?(directory)
end

Note that using a method is not necessary in the present case.

Totor
  • 1,148
  • 1
  • 10
  • 21
Emily
  • 17,813
  • 3
  • 43
  • 47
50

You can also use Dir::exist? like so:

Dir.exist?('Directory Name')

Returns true if the 'Directory Name' is a directory, false otherwise.1

Sᴀᴍ Onᴇᴌᴀ
  • 8,218
  • 8
  • 36
  • 58
ma11hew28
  • 121,420
  • 116
  • 450
  • 651
48

All the other answers are correct, however, you might have problems if you're trying to check directory in a user's home directory. Make sure you expand the relative path before checking:

File.exists? '~/exists'
=> false
File.directory? '~/exists'
=> false
File.exists? File.expand_path('~/exists')
=> true
Andrew
  • 227,796
  • 193
  • 515
  • 708
19
File.exist?("directory")

Dir[] returns an array, so it will never be nil. If you want to do it your way, you could do

Dir["directory"].empty?

which will return true if it wasn't found.

the Tin Man
  • 158,662
  • 42
  • 215
  • 303
cloudhead
  • 15,253
  • 6
  • 42
  • 37
7

You could use Kernel#test:

test ?d, 'some directory'

it gets it's origins from https://ss64.com/bash/test.html you will notice bash test has this flag -d to test if a directory exists -d file True if file is a Directory. [[ -d demofile ]]

jtzero
  • 2,204
  • 2
  • 25
  • 44